Greptile Summary

This PR migrates the database layer from sqlite3 (callback-based) to better-sqlite3 (synchronous), resolving security vulnerabilities in outdated dependencies and improving performance.

Key Changes:

• Replaced callback-based db.all() and db.get() with synchronous prepared statements (db.prepare().all() and .get())
• Write operations (INSERT/UPDATE/DELETE) now return empty arrays instead of result objects for backward compatibility
• Added directory creation logic in server/lib/db.js to prevent startup failures
• Fixed server/apis/comment.js to fetch newly inserted comment after insert (since insert no longer returns the row)
• Added manual cascade deletion in Plugin.deletePermanently() to handle related records (comments, downloads, purchase orders)
• Fixed type conversions: OTP values stringified, boolean-to-integer for is_default, increment values stringified
• Improved error handling and null safety across OTP and user APIs
• Client-side improvements: fixed comment ID handling and added deletion success feedback

Migration Quality:

• The migration is well-executed with proper synchronous error handling
• The developer correctly identified and fixed all callback-to-sync conversions
• Type conversions have been handled appropriately for SQLite's type system
• Previous review comments about syntax errors and missing closing braces were incorrect - the code structure is valid

Confidence Score: 4/5

• This PR is generally safe to merge with careful testing of database operations
• The migration is well-implemented with proper error handling and backward compatibility. However, the breaking changes to the database layer require thorough testing of all CRUD operations, especially edge cases around concurrent inserts and type conversions. The manual cascade deletion logic needs verification that it covers all foreign key relationships.
• Pay close attention to server/entities/entity.js (core database abstraction), server/entities/plugin.js (manual cascade logic), and server/apis/comment.js (post-insert fetch pattern)

Important Files Changed

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[sqlite3 with callbacks] -->|Migration| B[better-sqlite3 synchronous]
    B --> C[Database Layer<br/>server/lib/db.js]
    C --> D{Foreign Keys Enabled}
    D -->|Yes| E[Entity Layer<br/>server/entities/entity.js]
    E --> F[execSql: Prepared Statements]
    F --> G{Statement Type}
    G -->|SELECT| H[stmt.all returns rows]
    G -->|INSERT/UPDATE/DELETE| I[stmt.run returns empty array]
    I --> J[API Layer Adaptations]
    H --> J
    J --> K[Comment API<br/>Fetch after insert]
    J --> L[Plugin API<br/>Manual cascades]
    J --> M[User/OTP APIs<br/>Type conversions]

_{Last reviewed commit: 6b9dcad}

@greptileai Review it again.

@greptileai Review it again.

@greptileai Review changes.

@greptileai review again

@greptileai Review Once Again.